Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(blockifier): resource cost ratio type changed to u64 ratio from u128 ratio #1174

Merged
merged 1 commit into from
Oct 8, 2024
Merged

refactor(blockifier): resource cost ratio type changed to u64 ratio from u128 ratio #1174

merged 1 commit into from
Oct 8, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 6, 2024 •
edited by liorgold2
Loading

This change is Reviewable

@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Oct 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite Graphite

This was referenced Oct 6, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 6, 2024 07:20
@codecov Codecov
Copy link

codecov bot commented Oct 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.06%. Comparing base (b0cfe82) to head (ccb64a0).
Report is 257 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/execution/entry_point.rs 44.44% 3 Missing and 2 partials ⚠️
crates/blockifier/src/utils.rs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
- Coverage   74.18%   71.06%   -3.13%     
==========================================
  Files         359       86     -273     
  Lines       36240    11491   -24749     
  Branches    36240    11491   -24749     
==========================================
- Hits        26886     8166   -18720     
+ Misses       7220     2957    -4263     
+ Partials     2134      368    -1766
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from d32a194 to 1289853 Compare October 6, 2024 08:20
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 7441965 to b741627 Compare October 6, 2024 08:20
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from 1289853 to 2ad639a Compare October 6, 2024 08:32
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from b741627 to 8a7bb3b Compare October 6, 2024 08:32
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from 2ad639a to fd9d729 Compare October 6, 2024 13:50
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 8a7bb3b to 5dae256 Compare October 6, 2024 13:50
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from fd9d729 to 74c50d6 Compare October 6, 2024 14:02
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 5dae256 to 72730ea Compare October 6, 2024 14:02
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from 74c50d6 to 76ec0e3 Compare October 6, 2024 14:24
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 72730ea to 893e4f1 Compare October 6, 2024 14:24
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from 76ec0e3 to f67b6be Compare October 6, 2024 15:03
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 893e4f1 to 96cb7e1 Compare October 6, 2024 15:03
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from f67b6be to 6f1a5fb Compare October 6, 2024 15:28
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 96cb7e1 to 8dec550 Compare October 6, 2024 15:28
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch 2 times, most recently from a877b2b to 455529c Compare October 6, 2024 15:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 8dec550 to 372659d Compare October 6, 2024 15:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from 455529c to f28fdce Compare October 7, 2024 09:18
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 372659d to 123d82e Compare October 7, 2024 09:18
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from f28fdce to fe58aee Compare October 7, 2024 13:42
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 123d82e to ec9d68f Compare October 7, 2024 13:42
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from fe58aee to 9b4d1d0 Compare October 7, 2024 15:08
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from ec9d68f to 63552c1 Compare October 7, 2024 15:08
dorimedini-starkware
dorimedini-starkware commented Oct 7, 2024
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

crates/blockifier/src/test_utils.rs line 387 at r1 (raw file):

pub fn u64_from_usize(val: usize) -> u64 {
    val.try_into().unwrap()
}

this is no longer a test util

Code quote:

pub fn u64_from_usize(val: usize) -> u64 {
    val.try_into().unwrap()
}

@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from 9b4d1d0 to 26aa095 Compare October 7, 2024 15:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from 63552c1 to d3e8b3f Compare October 7, 2024 15:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee branch from 26aa095 to 3c2d2d7 Compare October 7, 2024 16:50
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from d3e8b3f to ff01543 Compare October 7, 2024 16:50
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-06-feat_blockifier_starknet_api_add_explcit_typing_and_arithmetic_to_gas_amount_price_and_fee to graphite-base/1174 October 7, 2024 17:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from ff01543 to a51fb1d Compare October 7, 2024 17:13
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/1174 to main October 7, 2024 17:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-refactor_blockifier_resource_cost_ratio_type_changed_to_u64_ratio_from_u128_ratio branch from a51fb1d to ccb64a0 Compare October 7, 2024 17:14
Yoni-Starkware
Yoni-Starkware approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit ab4fb11 into main Oct 8, 2024
11 checks passed
This was referenced Oct 8, 2024
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorimedini-starkware @Yoni-Starkware